miguel456/rbrecruiter
1
0
Fork 1
Code Issues Pull Requests 1 Projects Releases 2 Wiki Activity

WIP: Road to 1.0.0 #1

Draft
miguel456 wants to merge 123 commits from develop into master
pull from: develop
merge into: miguel456:master
Conversation 1 Commits 123 Files Changed 586 +41545 -29639
miguel456 commented 2020-12-07 18:57:05 +00:00
Owner
Copy Link

New features are currently under development in the develop branch.
These new features include (not an exhaustive list):

  • Teams (Done)
  • Team uploads (Done)
  • Upgrade to Laravel 8 (Done)
  • Team invitations (Done)
  • Simplification of application display
  • Translations: English, Portuguese, French

Other fixes:

  • Improvements to the code's style
  • Bug fixes to the installation command
  • New artisan user creation command
  • Other fixes to broken stuff in the master branch

This PR is currently work in progress as there are many other issues that need to be addressed as well as new features that are pending.
Merging this will release version 1.0.0.

New features are currently under development in the develop branch. These new features include (not an exhaustive list): * ~~Teams~~ (Done) * ~~Team uploads~~ (Done) * ~~Upgrade to Laravel 8~~ (Done) * ~~Team invitations~~ (Done) * Simplification of application display * Translations: English, Portuguese, French Other fixes: * Improvements to the code's style * Bug fixes to the installation command * New artisan user creation command * Other fixes to broken stuff in the master branch This PR is currently work in progress as there are many other issues that need to be addressed as well as new features that are pending. Merging this will release version ``1.0.0``.
miguel456 added the
enhancement
 label 2020-12-07 18:57:05 +00:00
miguel456 self-assigned this 2020-12-07 18:57:05 +00:00
miguel456 added 28 commits 2020-12-07 18:57:06 +00:00 
Adds user invitation to teams, and framework for assigning taems
Also adds user acc. deletion.
RSM-19 feature

Approved-by: Miguel Nogueira <miguel456@spacejewel-hosting.com>
Apply fixes from StyleCI
Apply fixes from StyleCI
# Conflicts:
#	app/Http/Controllers/TeamFileController.php
#	app/TeamFile.php
#	config/adminlte.php
#	routes/web.php
miguel456 added the due date 2020-12-10 2020-12-07 18:58:02 +00:00
miguel456 added 3 commits 2020-12-08 00:07:59 +00:00 
This method would always fail for cached options because at the end it was expecting an Eloquent model, which would never be populated if the requested value was cached in the first place.

Uncached requests wouldn't fail because the exec path would lead to $value being a Model.

Also removed reference to old feature causing application page to crash.
miguel456 added 2 commits 2020-12-08 03:10:02 +00:00
miguel456 added 1 commit 2020-12-08 14:56:30 +00:00
miguel456 added 1 commit 2020-12-19 03:13:41 +00:00
miguel456 added 1 commit 2020-12-19 04:09:39 +00:00
miguel456 added 1 commit 2020-12-19 20:38:49 +00:00
miguel456 removed the due date 2020-12-10 2020-12-19 20:39:34 +00:00
miguel456 added this to the 1.0.0 - Roadmap project 2020-12-19 20:44:21 +00:00
miguel456 added 2 commits 2020-12-20 04:40:59 +00:00 
Reviewed-on: https://code.spacejewel-hosting.com/spacejewelhosting/staffmanager/pulls/3
miguel456 added 5 commits 2020-12-20 14:15:50 +00:00 
Reviewed-on: https://code.spacejewel-hosting.com/spacejewelhosting/staffmanager/pulls/4
miguel456 added 3 commits 2020-12-20 16:36:37 +00:00 
Reviewed-on: https://code.spacejewel-hosting.com/spacejewelhosting/staffmanager/pulls/5
Proximity added 1 commit 2020-12-20 16:39:32 +00:00
miguel456 added 1 commit 2020-12-20 16:53:18 +00:00
Proximity added 2 commits 2020-12-20 16:54:38 +00:00
Proximity added 1 commit 2020-12-20 17:07:02 +00:00
Proximity added 2 commits 2020-12-20 17:11:37 +00:00
Proximity added 1 commit 2020-12-20 17:13:13 +00:00
Proximity added 1 commit 2020-12-20 17:15:07 +00:00
Proximity added 1 commit 2020-12-20 17:57:53 +00:00
miguel456 started working 2020-12-20 23:33:46 +00:00
miguel456 canceled time tracking 2020-12-20 23:33:52 +00:00
miguel456 added 2 commits 2020-12-21 00:48:40 +00:00 
TeamSeeder previously created permissions that already existed, if the migration had ran twice. This commit forces the seeder to verify if the permission it's attempting to create already exists, and if not, it creates it and assigns them at the end.

THis prevents an error from appearing if these permissions were created manually. In this case, the seeder will only assign the permissions instead of creating them.
miguel456 added 1 commit 2020-12-21 01:04:36 +00:00 
Gate Auth arguments were missing for TeamFile and Team controllers.
This means that Gate has no idea where to look for policies, meaning that
the ability passed is perceived literally, causing an Unauthorized error.

Adding the Model with which to authorize the request solved the error since
Gate now knows which policy to look in for permission logic.
miguel456 added 1 commit 2020-12-21 01:20:54 +00:00
Proximity added 1 commit 2020-12-24 03:59:38 +00:00
miguel456 added 2 commits 2020-12-30 00:12:15 +00:00 
This commit adds third party integrations to the settings page.
It will allow users to link the games and services their community is using, to facilitate recruiting in each service.
These settings are not saved yet.
miguel456 added 1 commit 2021-01-06 00:19:07 +00:00
miguel456 added 1 commit 2021-01-06 00:57:34 +00:00
miguel456 added 1 commit 2021-01-06 01:02:54 +00:00
miguel456 added 1 commit 2021-01-06 01:29:09 +00:00 
This categorization system aims to prevent mixing different options together.
miguel456 added 1 commit 2021-01-06 01:29:53 +00:00
miguel456 added 1 commit 2021-01-06 01:31:04 +00:00
miguel456 added 1 commit 2021-01-06 01:55:44 +00:00
miguel456 added 1 commit 2021-01-06 02:11:54 +00:00
miguel456 added 1 commit 2021-01-06 03:22:45 +00:00
miguel456 added 1 commit 2021-01-06 03:25:28 +00:00
miguel456 added 1 commit 2021-01-06 03:48:21 +00:00 
Also adds a warning for when pw policy is set to off
miguel456 added 1 commit 2021-01-06 05:03:46 +00:00 
This commit applies the password_expiration setting to all users.
Users won't be able to do anything other than update password until it's done.
miguel456 added 1 commit 2021-01-27 02:02:05 +00:00
miguel456 added 1 commit 2021-01-27 02:07:38 +00:00
miguel456 added 1 commit 2021-01-27 02:23:34 +00:00 
This commit changes the deletion mechanism for forms. Currently, it sets the wanted deletion ID to the session, and redirects the user to the previous page, to open a confirmation dialog for deletion.
miguel456 added 1 commit 2021-01-27 02:26:16 +00:00
miguel456 added 1 commit 2021-01-27 02:32:02 +00:00
miguel456 added 1 commit 2021-01-27 02:35:59 +00:00
miguel456 added 1 commit 2021-01-29 16:27:44 +00:00
miguel456 added 1 commit 2021-01-29 16:56:33 +00:00
miguel456 added 1 commit 2021-01-29 16:58:01 +00:00
miguel456 added 1 commit 2021-01-29 17:00:39 +00:00
miguel456 added 1 commit 2021-01-29 17:12:41 +00:00
miguel456 added 1 commit 2021-01-29 17:20:32 +00:00 
This approach would allow users to directly use HTML in their responses. We'd need to purify HTML on the way out to only allow <br>, otherwise, there'd be XSS concerns.

Rendering as Markdown and letting users know they can use it is a better approach in the long run.
miguel456 added 1 commit 2021-01-29 17:27:07 +00:00
miguel456 added 1 commit 2021-01-29 17:28:34 +00:00
miguel456 added 1 commit 2021-01-29 17:32:48 +00:00
miguel456 added 1 commit 2021-01-29 17:34:49 +00:00
miguel456 added 5 commits 2021-03-31 14:51:05 +00:00
miguel456 added 1 commit 2021-03-31 15:16:21 +00:00
miguel456 added 1 commit 2021-03-31 18:39:53 +00:00
miguel456 added 1 commit 2021-03-31 18:53:33 +00:00
miguel456 added 1 commit 2021-07-19 23:35:14 +00:00
miguel456 added 1 commit 2021-07-20 09:32:52 +00:00 
Refactored some old code and added missing translation calls.
miguel456 commented 2021-07-20 09:37:38 +00:00
Author
Owner
Copy Link

TODO: Change translation scheme to JSON file with all strings, and not confusing translation keys

TODO: Change translation scheme to JSON file with all strings, and not confusing translation keys
miguel456 added 1 commit 2021-07-20 21:35:59 +00:00 
Implemented a Reddit-like account suspension system (similar to subreddit bans). This makes it easier to ban users from the app, and the code has also been cleaned up.

The interface was also revamped.
miguel456 added 2 commits 2021-07-25 21:54:29 +00:00 
In preparation to the upcoming API, most logic is being moved to services. Models function as repositories.
This commit moves most controller logic onto Services. Services are part of the Service-Repository pattern. The models act as repositories.

Services are easily testable and are needed for the upcoming API, in order to avoid duplicated code and to maintain a single source of "truth".

 The User, Vacancy and Vote controllers still need their logic moved onto services.
miguel456 added 1 commit 2021-09-03 23:45:07 +00:00 
Demo mode allows to safely run a demo version of the app, with destructive features limited.

Some bugs were also fixed in this commit.
miguel456 added 1 commit 2021-09-04 01:56:28 +00:00 
Also disabled IP history logger for demo mode
miguel456 added 1 commit 2021-09-04 12:50:53 +00:00
miguel456 added 1 commit 2021-09-04 13:27:41 +00:00
miguel456 added 6 commits 2021-10-12 23:03:38 +00:00 
This exception is thrown and handled when Mojang servers are down.
miguel456 added 2 commits 2021-10-13 00:22:14 +00:00 
This reverts commit 42178e26de, reversing
changes made to d876dd6055.
miguel456 added 1 commit 2021-10-13 00:24:55 +00:00
miguel456 added 2 commits 2021-10-13 00:47:39 +00:00 
This reverts commit fc6d7d2b18.
This reverts commit 64d8ffa9d9.
miguel456 added 1 commit 2021-10-13 00:55:29 +00:00 
This reverts commit 427c9d1c57.
*facepalm*
miguel456 added 1 commit 2021-10-13 01:57:10 +00:00 
This reverts commit 2ddef6058d.
miguel456 added 1 commit 2021-10-13 03:07:22 +00:00
miguel456 started working 2022-04-20 22:55:03 +00:00
miguel456 stopped working 2022-04-20 22:55:11 +00:00
8s
miguel456 deleted spent time 2022-04-20 22:55:19 +00:00
- 8s
This pull request is marked as a work in progress.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin develop:develop
git checkout develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
1.0.0 - Roadmap
Assignees
Clear assignees
No Assignees
miguel456
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: miguel456/rbrecruiter#1
No description provided.
Delete Branch "develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?