Expand and simplify vacancy update notification

app/Http/Controllers/VacancyController.php

@@ -25,10 +25,11 @@ use App\Facades\JSON;
 use App\Form;
 use App\Http\Requests\VacancyEditRequest;
 use App\Http\Requests\VacancyRequest;
-use App\Notifications\VacancyClosed;
+use App\Notifications\VacancyStatusUpdated;
 use App\User;
 use App\Vacancy;
 use Illuminate\Http\Request;
+use Illuminate\Support\Facades\Notification;
 use Illuminate\Support\Str;
 
 class VacancyController extends Controller
@@ -102,11 +103,6 @@ class VacancyController extends Controller
                     $vacancy->close();
                     $message = __('Position successfully closed!');
 
-                    foreach (User::all() as $user) { // Avoid the ghost account
-                        if ($user->isStaffMember() && $user->id != 1) {
-                            $user->notify(new VacancyClosed($vacancy));
-                        }
-                    }
                     break;
 
                 default:
@@ -114,11 +110,17 @@ class VacancyController extends Controller
                     $type = 'error';
 
             }
+
+
         } else {
             $message = __("The position you're trying to update doesn't exist!");
             $type = 'error';
         }
 
+        if ($type !== 'error') {
+            Notification::send(User::role('reviewer')->get(), new VacancyStatusUpdated($vacancy, $status));
+        }
+
         return redirect()
             ->back()
             ->with($type, $message);

app/Notifications/VacancyStatusUpdated.php

@@ -30,20 +30,30 @@ use Illuminate\Notifications\Messages\MailMessage;
 use Illuminate\Notifications\Notification;
 use Illuminate\Queue\SerializesModels;
 
-class VacancyClosed extends Notification implements ShouldQueue
+class VacancyStatusUpdated extends Notification implements ShouldQueue
 {
     use Queueable, SerializesModels, Cancellable;
 
-    protected $vacancy;
+    protected string $status;
+
+
+    protected Vacancy $vacancy;
 
     /**
      * Create a new notification instance.
      *
      * @return void
      */
-    public function __construct(Vacancy $vacancy)
+    public function __construct(Vacancy $vacancy, $status)
     {
+        // there's no simpler solution to this for now, but an array works
+        $statusDict = [
+            'open' => 'opened',
+            'close' => 'closed'
+        ];
+
         $this->vacancy = $vacancy;
+        $this->status = $statusDict[$status];
     }
 
     public function optOut($notifiable)
@@ -59,12 +69,14 @@ class VacancyClosed extends Notification implements ShouldQueue
      */
     public function toMail($notifiable)
     {
+
         return (new MailMessage)
                     ->greeting('Hi ' . $notifiable->name . ',')
                     ->from(config('notification.sender.address'), config('notification.sender.name'))
-                    ->subject(config('app.name').' - Vacancy Closed')
-                    ->line('The vacancy '.$this->vacancy->vacancyName.', with '.$this->vacancy->vacancyCount.' remaining slots, has just been closed.')
-                    ->line('Please be aware that this position may be deleted/reopened any time.')
+                    ->subject(config('app.name').' - Vacancy ' . $this->status)
+                    ->line('The vacancy '.$this->vacancy->vacancyName.', with '.$this->vacancy->vacancyCount.' remaining slots, has just been ' . $this->status . '.')
+                    ->line('Please be aware that this position may be change at any time.')
+                    ->line('You are receiving this email because you currently have staff/team member privileges. Depending on your access level, you may not be able to view the list of positions on the backoffice.')
                     ->action('View positions', url(route('showPositions')))
                     ->salutation('The team at ' . config('app.name'));
     }