miguel456/tasklist-backend
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: add CORS handling

Browse Source
This commit is contained in:
Miguel Nogueira
2025-04-16 18:51:53 +01:00
parent 646655bc50
commit 18cfc7adba
3 changed files with 46 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/Controllers/TaskController.php
View File

@@ -16,7 +16,8 @@ use Utils\StructuredResponseBuilder;
class TaskController
{
private $repository, $builder;
private StructuredResponseBuilder $builder;
private TaskRepository $repository;
// instead of requesting the builder here, we could simply make it static
public function __construct(TaskRepository $taskRepository, StructuredResponseBuilder $builder)
@@ -34,7 +35,7 @@ class TaskController
$requiredKeys = ['name', 'description', 'status', 'start', 'end'];
if (!array_key_exists('tasks', $params)) {
if (!array_key_exists('payload', $params)) {
$this->builder->setError();
$this->builder->setErrorMessage('Malformed request payload. Please try again.');
$this->builder->setErrorCode(400);
@@ -48,7 +49,7 @@ class TaskController
$missingKeys = [];
foreach ($requiredKeys as $key)
{
if (!array_key_exists($key, $params['tasks'])) {
if (!array_key_exists($key, $params['payload'])) {
$missingKeys[] = $key;
}
}
@@ -66,8 +67,8 @@ class TaskController
try
{
$start = Carbon::parse($params['tasks']['start']);
$end = Carbon::parse($params['tasks']['end']);
$start = Carbon::parse($params['payload']['start']);
$end = Carbon::parse($params['payload']['end']);
if ($start->gt($end) || $end->lt($start)) {
throw new InvalidTaskDateException('Invalid task date. Start date must not be after end date.');
@@ -85,7 +86,7 @@ class TaskController
return $errorResponse;
}
if (is_null(TaskStatus::tryFrom($params['tasks']['status']))) {
if (is_null(TaskStatus::tryFrom($params['payload']['status']))) {
$this->builder->setError();
$this->builder->setErrorCode(400);
$this->builder->setErrorMessage('Invalid task status code. Status must range from 1-4 (started, in progress, blocked, completed).');
@@ -97,11 +98,11 @@ class TaskController
}
$task = new Task();
$task->setName($params['tasks']['name'])
->setStatusId(TaskStatus::tryFrom((int) $params['tasks']['status']))
->setDescription($params['tasks']['description'])
->setStart($params['tasks']['start'])
->setEnd($params['tasks']['end']);
$task->setName($params['payload']['name'])
->setStatusId(TaskStatus::tryFrom((int) $params['payload']['status']))
->setDescription($params['payload']['description'])
->setStart($params['payload']['start'])
->setEnd($params['payload']['end']);
$createdTask = $this->repository->create($task);
@@ -133,7 +134,7 @@ class TaskController
$this->builder->setPayload($payload)->setOptionalMessage('Listing all tasks: ');
$response->getBody()->write($this->builder->build());
return $response;
return $response->withHeader('Content-Type', 'application/json');
}
public function getTask(ServerRequestInterface $request, ResponseInterface $response, string $id): ResponseInterface
@@ -144,12 +145,12 @@ class TaskController
$this->builder->setPayload($payload)->setOptionalMessage("Task retrieved.");
$response->getBody()->write($this->builder->build());
return $response;
return $response->withHeader('Content-Type', 'application/json');
} catch (TaskNotFoundException $e) {
$this->builder->setError()->setErrorMessage($e->getMessage())->setErrorCode(404);
$errorResponse = $response->withStatus(404, $e->getMessage());
$errorResponse = $response->withStatus(404, $e->getMessage())->withHeader('Content-Type', 'application/json');
$response->getBody()->write($this->builder->build());
return $errorResponse;
@@ -166,7 +167,7 @@ class TaskController
$this->builder->setOptionalMessage('Task deleted.');
$response->getBody()->write($this->builder->build());
return $response;
return $response->withHeader('Content-Type', 'application/json');
} catch (TaskNotFoundException $exception)
{
@@ -175,7 +176,7 @@ class TaskController
$errorResponse = $response->withStatus(404);
$errorResponse->getBody()->write($this->builder->build());
return $errorResponse;
return $errorResponse->withHeader('Content-Type', 'application/json');
}
}