Commit Graph

18 Commits

Author SHA1 Message Date
Miguel Nogueira 620453c1e4
Separation of Concerns + old coude cleanup 2021-07-20 00:35:03 +01:00
Miguel Nogueira 96aa01b9c6 Recent changes 2020-11-02 21:44:05 +00:00
Miguel Nogueira 6541e25a39 Apply fixes from StyleCI 2020-10-10 16:30:26 +00:00
Miguel Nogueira 8e85e08171 Vacancy tweaks 2020-09-03 02:52:21 +01:00
Miguel Nogueira de3dba3627 Vacancy tweaks 2020-09-03 02:50:19 +01:00
Miguel Nogueira 7e58c3af6b Add more missing translation strings
Also fixed broken vacancy editor
2020-09-03 02:20:15 +01:00
Miguel Nogueira ad5c3404cc
Update variable 2020-07-25 01:20:43 +01:00
Miguel Nogueira 62b063ee63
Missed variable name 2020-07-23 02:37:08 +01:00
Miguel Nogueira 5f1f92a9ce Code review
This commit fixes some superficial instances of Broken Access Control 
(https://owasp.org/www-project-top-ten/OWASP_Top_Ten_2017/Top_10-2017_A5-Broken_Access_Control).
There may be some more instances of this, as authorization was only done 
after most of the controllers were done (big mistake).

Some refactoring was also performed, where Route Model Binding with DI 
(dependency injection) was used whenever possible, to increase 
testability of the codebase.
Some reused code was also moved to Helper classes as to enforce DRY; 
There may be some lines of code that are still copy-pasted from other 
parts of the codebase for reuse.

Non-breaking refactoring changes were made, but the app as a whole still 
needs full manual testing, and customised responses to HTTP 500 
responses. Some errors are also not handled gracefully and this wasn't 
checked in this commit.
2020-07-16 21:21:28 +01:00
Miguel Nogueira e978a5417b Added ability to delete single application
Also moved User observer code to Application observer
2020-07-12 17:01:33 +01:00
Miguel Nogueira bd0664ce0d Add ability to edit Vacancies 2020-07-11 20:34:26 +01:00
Miguel Nogueira 4b390ea536 Added full Vacancy description
Also added support for Markdown
2020-07-11 05:34:12 +01:00
Miguel Nogueira 33c16fcf46 Add user directory & isolate authorisation 2020-06-27 19:15:33 +01:00
Miguel Nogueira 5a8c080a31 Beta version
This commit is too large to list all changes.
2020-06-27 00:32:33 +01:00
Miguel Nogueira 4c6a435e34 Entrypoint: Add Application Page
This commit finally adds the dynamically rendered form that changes according to how the user builds their form.
It also fragments the header and footer for the main page into their own separate files for ease of access later.
Vacancy status has also been added to the Vacancies in DB.
All staff application endpoints have also been moved to under the user application endpoints group, for ease of use (duplicated route group).
2020-05-08 06:06:24 +01:00
Miguel Nogueira a4e415943a Add save & update functionality to positions
Tooltips also added, as well as a general configuration file for Mojang Status URL.
Relationships were also added between forms and Vacancies.
Status verification for the dashboard was moved to a Service Provider, where it adds log entries when cache expires.
Authentication controllers were also updated to reflect the new dashboard URL.
2020-05-08 00:24:56 +01:00
Miguel Nogueira 27794729b9 Added vacancies list 2020-05-03 05:04:26 +01:00
Miguel Nogueira 7c22894e94 Added models, migrations and controllers
This commit adds the logical structure for the app.
2020-04-29 18:15:54 +01:00