Commit Graph

7 Commits

Author SHA1 Message Date
8942623bde
Added services
This commit moves most controller logic onto Services. Services are part of the Service-Repository pattern. The models act as repositories.

Services are easily testable and are needed for the upcoming API, in order to avoid duplicated code and to maintain a single source of "truth".

 The User, Vacancy and Vote controllers still need their logic moved onto services.
2021-07-25 22:54:15 +01:00
620453c1e4
Separation of Concerns + old coude cleanup 2021-07-20 00:35:03 +01:00
96aa01b9c6 Recent changes 2020-11-02 21:44:05 +00:00
6541e25a39 Apply fixes from StyleCI 2020-10-10 16:30:26 +00:00
5f1f92a9ce Code review
This commit fixes some superficial instances of Broken Access Control 
(https://owasp.org/www-project-top-ten/OWASP_Top_Ten_2017/Top_10-2017_A5-Broken_Access_Control).
There may be some more instances of this, as authorization was only done 
after most of the controllers were done (big mistake).

Some refactoring was also performed, where Route Model Binding with DI 
(dependency injection) was used whenever possible, to increase 
testability of the codebase.
Some reused code was also moved to Helper classes as to enforce DRY; 
There may be some lines of code that are still copy-pasted from other 
parts of the codebase for reuse.

Non-breaking refactoring changes were made, but the app as a whole still 
needs full manual testing, and customised responses to HTTP 500 
responses. Some errors are also not handled gracefully and this wasn't 
checked in this commit.
2020-07-16 21:21:28 +01:00
7cf056f57e Switch custom Guzzle integration for Laravel's HTTP facade
Commit also adds config options to the example file.
2020-05-02 20:18:56 +01:00
3bd773e2d3 Added main page
This commit adds the main page (incl. breadcrumbs), a license file, a contact form (with recaptcha) and a captcha config file.
2020-04-27 07:28:00 +01:00