Added ability to delete single application

Also moved User observer code to Application observer

app/Http/Controllers/ApplicationController.php

@@ -282,4 +282,16 @@ class ApplicationController extends Controller
 
         return redirect()->back();
     }
+
+    public function delete(Request $request, Application $application)
+    {
+
+      $this->authorize('delete', $application);
+      $application->delete(); // observers will run, cleaning it up
+
+      $request->session()->flash('success', 'Application deleted. Comments, appointments and responses have also been deleted.');
+      return redirect()->back();
+      
+    }
+
 }

app/Http/Controllers/VacancyController.php

@@ -114,6 +114,7 @@ class VacancyController extends Controller
 
     public function edit(Request $request, Vacancy $position)
     {
+       $this->authorize('update', $vacancy);
         return view('dashboard.administration.editposition')
                ->with('vacancy', $position);
     }
@@ -122,6 +123,7 @@ class VacancyController extends Controller
 
     public function update(VacancyEditRequest $request, Vacancy $position)
     {
+      $this->authorize('update', $vacancy);
 
       $position->vacancyFullDescription = $request->vacancyFullDescription;
       $position->vacancyDescription = $request->vacancyDescription;

app/Observers/ApplicationObserver.php

@@ -0,0 +1,93 @@
+<?php
+
+namespace App\Observers;
+
+use App\Application;
+
+class ApplicationObserver
+{
+    /**
+     * Handle the application "created" event.
+     *
+     * @param  \App\Application  $application
+     * @return void
+     */
+    public function created(Application $application)
+    {
+        //
+    }
+
+    /**
+     * Handle the application "updated" event.
+     *
+     * @param  \App\Application  $application
+     * @return void
+     */
+    public function updated(Application $application)
+    {
+        //
+    }
+
+    public function deleting(Application $application)
+    {
+        $application->response()->delete();
+        $votes = $application->votes;
+
+        foreach ($votes as $vote)
+        {
+            Log::debug('Referential integrity cleanup: Deleting and detaching vote ' . $vote->id);
+            $vote->application()->detach($application->id);
+            $vote->delete();
+        }
+
+        if (!is_null($application->appointment))
+        {
+            Log::debug('RIC: Deleting appointment!');
+            $application->appointment()->delete();
+        }
+
+        if (!$application->comments->isEmpty())
+        {
+            Log::debug('RIC: Deleting comments!');
+            foreach($application->comments as $comment)
+            {
+                $comment->delete();
+            }
+        }
+
+        // application can now be deleted 
+    }
+
+    /**
+     * Handle the application "deleted" event.
+     *
+     * @param  \App\Application  $application
+     * @return void
+     */
+    public function deleted(Application $application)
+    {
+        //
+    }
+
+    /**
+     * Handle the application "restored" event.
+     *
+     * @param  \App\Application  $application
+     * @return void
+     */
+    public function restored(Application $application)
+    {
+        //
+    }
+
+    /**
+     * Handle the application "force deleted" event.
+     *
+     * @param  \App\Application  $application
+     * @return void
+     */
+    public function forceDeleted(Application $application)
+    {
+        //
+    }
+}

app/Observers/UserObserver.php

@@ -48,30 +48,7 @@ class UserObserver
             Log::debug('RIC: Now trying to delete applications and responses...');
             foreach($applications as $application)
             {
-                $application->response()->delete();
-                $votes = $application->votes;
-
-                foreach ($votes as $vote)
-                {
-                    Log::debug('RIC: Deleting and detaching vote ' . $vote->id);
-                    $vote->application()->detach($application->id);
-                    $vote->delete();
-                }
-
-                if (!is_null($application->appointment))
-                {
-                    Log::debug('RIC: Deleting appointment!');
-                    $application->appointment()->delete();
-                }
-
-                if (!$application->comments->isEmpty())
-                {
-                    Log::debug('RIC: Deleting comments!');
-                    foreach($application->comments as $comment)
-                    {
-                        $comment->delete();
-                    }
-                }
+                // code moved to Application observer, where it gets rid of attached elements individually
                 Log::debug('RIC: Deleting application ' . $application->id);
                 $application->delete();
 

app/Policies/ApplicationPolicy.php

@@ -45,4 +45,11 @@ class ApplicationPolicy
     {
         return $user->hasAnyRole('admin', 'hiringManager');
     }
+
+    public function delete(User $user, Application $application)
+    {
+
+      return $user->hasRole('admin');
+
+    }
 }

app/View/Components/NoPermission.php

@@ -0,0 +1,33 @@
+<?php
+
+namespace App\View\Components;
+
+use Illuminate\View\Component;
+
+class NoPermission extends Component
+{
+    public $type;
+
+    public $inDashboard;
+    /**
+     * Create a new component instance.
+     *
+     * @return void
+     */
+    public function __construct($type, $inDashboard = true)
+    {
+      $this->type = $type;
+
+      $this->inDashboard = $inDashboard;
+    }
+
+    /**
+     * Get the view / contents that represent the component.
+     *
+     * @return \Illuminate\View\View|string
+     */
+    public function render()
+    {
+        return view('components.no-permission');
+    }
+}