From 0bdb6cf2fb43380cd9026d6eb9a94b6077626259 Mon Sep 17 00:00:00 2001
From: Miguel Nogueira <miguel456@spacejewel-hosting.com>
Date: Mon, 7 Dec 2020 17:48:15 +0000
Subject: [PATCH] Minor fixes

---
 .../Controllers/ApplicationController.php     |  2 +-
 ..._10_04_124115_vacancy_nullable_team_id.php | 53 -------------------
 database/seeders/DatabaseSeeder.php           |  1 -
 database/seeders/TeamFileSeeder.php           | 38 -------------
 resources/views/dashboard/dashboard.blade.php |  2 -
 5 files changed, 1 insertion(+), 95 deletions(-)
 delete mode 100755 database/migrations/2020_10_04_124115_vacancy_nullable_team_id.php
 delete mode 100755 database/seeders/TeamFileSeeder.php

diff --git a/app/Http/Controllers/ApplicationController.php b/app/Http/Controllers/ApplicationController.php
index cf38a33..7b74341 100755
--- a/app/Http/Controllers/ApplicationController.php
+++ b/app/Http/Controllers/ApplicationController.php
@@ -35,7 +35,7 @@ use Illuminate\Support\Facades\Log;
 
 class ApplicationController extends Controller
 {
-    private function canVote($votes)
+    private function canVote($votes): bool
     {
         $allvotes = collect([]);
 
diff --git a/database/migrations/2020_10_04_124115_vacancy_nullable_team_id.php b/database/migrations/2020_10_04_124115_vacancy_nullable_team_id.php
deleted file mode 100755
index 6fff503..0000000
--- a/database/migrations/2020_10_04_124115_vacancy_nullable_team_id.php
+++ /dev/null
@@ -1,53 +0,0 @@
-<?php
-
-/*
- * Copyright © 2020 Miguel Nogueira
- *
- *   This file is part of Raspberry Staff Manager.
- *
- *     Raspberry Staff Manager is free software: you can redistribute it and/or modify
- *     it under the terms of the GNU General Public License as published by
- *     the Free Software Foundation, either version 3 of the License, or
- *     (at your option) any later version.
- *
- *     Raspberry Staff Manager is distributed in the hope that it will be useful,
- *     but WITHOUT ANY WARRANTY; without even the implied warranty of
- *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *     GNU General Public License for more details.
- *
- *     You should have received a copy of the GNU General Public License
- *     along with Raspberry Staff Manager.  If not, see <https://www.gnu.org/licenses/>.
- */
-
-use Illuminate\Database\Migrations\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
-
-class VacancyNullableTeamId extends Migration
-{
-    /**
-     * Run the migrations.
-     *
-     * @return void
-     */
-    public function up()
-    {
-        Schema::table('vacancies', function (Blueprint $table) {
-            $table->dropForeign('vacancies_ownerteamid_foreign');
-            $table->dropColumn('ownerTeamID');
-            $table->bigInteger('team_id')->nullable()->unsigned();
-        });
-    }
-
-    /**
-     * Reverse the migrations.
-     *
-     * @return void
-     */
-    public function down()
-    {
-        Schema::table('vacancies', function (Blueprint $table) {
-            $table->dropColumn('team_id');
-        });
-    }
-}
diff --git a/database/seeders/DatabaseSeeder.php b/database/seeders/DatabaseSeeder.php
index 51ae93b..7aa686b 100755
--- a/database/seeders/DatabaseSeeder.php
+++ b/database/seeders/DatabaseSeeder.php
@@ -37,6 +37,5 @@ class DatabaseSeeder extends Seeder
         $this->call(DefaultOptionsSeeder::class);
         $this->call(NewPermissions::class);
         $this->call(TeamSeeder::class);
-        $this->call(TeamFileSeeder::class);
     }
 }
diff --git a/database/seeders/TeamFileSeeder.php b/database/seeders/TeamFileSeeder.php
deleted file mode 100755
index 4e44a98..0000000
--- a/database/seeders/TeamFileSeeder.php
+++ /dev/null
@@ -1,38 +0,0 @@
-<?php
-
-/*
- * Copyright © 2020 Miguel Nogueira
- *
- *   This file is part of Raspberry Staff Manager.
- *
- *     Raspberry Staff Manager is free software: you can redistribute it and/or modify
- *     it under the terms of the GNU General Public License as published by
- *     the Free Software Foundation, either version 3 of the License, or
- *     (at your option) any later version.
- *
- *     Raspberry Staff Manager is distributed in the hope that it will be useful,
- *     but WITHOUT ANY WARRANTY; without even the implied warranty of
- *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *     GNU General Public License for more details.
- *
- *     You should have received a copy of the GNU General Public License
- *     along with Raspberry Staff Manager.  If not, see <https://www.gnu.org/licenses/>.
- */
-
-namespace Database\Seeders;
-
-use App\TeamFile;
-use Illuminate\Database\Seeder;
-
-class TeamFileSeeder extends Seeder
-{
-    /**
-     * Run the database seeds.
-     *
-     * @return void
-     */
-    public function run()
-    {
-        TeamFile::factory()->count(50)->create();
-    }
-}
diff --git a/resources/views/dashboard/dashboard.blade.php b/resources/views/dashboard/dashboard.blade.php
index 81ee4d5..f6b516e 100755
--- a/resources/views/dashboard/dashboard.blade.php
+++ b/resources/views/dashboard/dashboard.blade.php
@@ -154,7 +154,6 @@
               <div class="icon">
                 <i class="fas fa-plus"></i>
               </div>
-              <a href="{{ route('staffPendingApps') }}" class="small-box-footer">{{__('messages.open')}} <i class="fas fa-arrow-circle-right"></i></a>
             </div>
           </div>
           <!-- ./col -->
@@ -169,7 +168,6 @@
               <div class="icon">
                 <i class="fas fa-vote-yea"></i>
               </div>
-              <a href="{{ route('peerReview') }}" class="small-box-footer">{{__('messages.open')}} <i class="fas fa-arrow-circle-right"></i></a>
             </div>
           </div>
           <!-- ./col -->