fix: add constraint actions to db structure

This commit adds several missing "cascade delete" actions to relationships on database tables. This effectively fixes errors while trying to delete user accounts because of pending child records.

Additionally, the observers for applications and vacancies were removed, since they are now obsolete.

The account deletion system was also refactored.

database/migrations/2020_04_29_022245_create_profiles_table.php

@@ -46,7 +46,8 @@ class CreateProfilesTable extends Migration
 
             $table->foreign('userID')
                 ->references('id')
-                ->on('users');
+                ->on('users')
+                ->cascadeOnDelete();
         });
     }
 

database/migrations/2020_04_29_022402_create_applications_table.php

@@ -53,7 +53,8 @@ class CreateApplicationsTable extends Migration
 
             $table->foreign('applicantUserID')
                 ->references('id')
-                ->on('users');
+                ->on('users')
+                ->cascadeOnDelete();
         });
     }
 

database/migrations/2020_04_29_022421_create_votes_table.php

@@ -43,7 +43,8 @@ class CreateVotesTable extends Migration
 
             $table->foreign('userID')
                 ->references('id')
-                ->on('users');
+                ->on('users')
+                ->cascadeOnDelete();
         });
     }
 

database/migrations/2020_04_29_022442_create_appointments_table.php

@@ -54,7 +54,8 @@ class CreateAppointmentsTable extends Migration
 
             $table->foreign('applicationID')
                 ->references('id')
-                ->on('applications');
+                ->on('applications')
+                ->cascadeOnDelete();
         });
     }
 

database/migrations/2020_04_29_030107_create_responses_table.php

@@ -41,7 +41,8 @@ class CreateResponsesTable extends Migration
             // A better way would be to link responses directly to vacancies, that subsquently have a form
             $table->foreign('responseFormID')
                 ->references('id')
-                ->on('forms');
+                ->on('forms')
+                ->cascadeOnDelete();
         });
     }
 

database/migrations/2020_04_29_195848_votes_has_application.php

@@ -38,8 +38,8 @@ class VotesHasApplication extends Migration
             $table->bigInteger('application_id')->unsigned();
             $table->timestamps();
 
-            $table->foreign('vote_id')->references('id')->on('votes');
-            $table->foreign('application_id')->references('id')->on('applications');
+            $table->foreign('vote_id')->references('id')->on('votes')->cascadeOnDelete();
+            $table->foreign('application_id')->references('id')->on('applications')->cascadeOnDelete();
         });
     }
 

database/migrations/2020_06_08_153602_create_bans_table.php

@@ -43,7 +43,8 @@ class CreateBansTable extends Migration
 
             $table->foreign('userID')
                 ->references('id')
-                ->on('users');
+                ->on('users')
+                ->cascadeOnDelete();
         });
     }
 

database/migrations/2020_06_20_210255_create_comments_table.php

@@ -41,11 +41,13 @@ class CreateCommentsTable extends Migration
 
             $table->foreign('authorID')
                 ->references('id')
-                ->on('users');
+                ->on('users')
+                ->cascadeOnDelete();
 
             $table->foreign('applicationID')
                 ->references('id')
-                ->on('applications');
+                ->on('applications')
+                ->cascadeOnDelete();
         });
     }
 

database/migrations/2022_02_02_060702_create_absences_table.php

@@ -27,11 +27,13 @@ class CreateAbsencesTable extends Migration
 
             $table->foreign('requesterID')
                 ->references('id')
-                ->on('users');
+                ->on('users')
+                ->onDelete('cascade');
 
             $table->foreign('reviewer')
                 ->references('id')
-                ->on('users');
+                ->on('users')
+                ->onDelete('set null');
         });
     }
 

database/migrations/2022_03_07_180241_remove_account_tokens_from_user.php

@@ -0,0 +1,32 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::table('users', function (Blueprint $table) {
+            $table->dropColumn('account_tokens');
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::table('users', function (Blueprint $table) {
+            $table->string('account_tokens')->after('password')->nullable();
+        });
+    }
+};