miguel456/athenahr
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: remove unnecessary notified flag updates in invitation processing

Browse Source 
this flag should only be used by post-processing jobs (e.g. invite lifecycle cleanup)

Signed-off-by: Miguel Nogueira <me@nogueira.codes>
This commit is contained in:
Miguel Nogueira
2025-08-10 11:03:29 +01:00
parent d48b35e845
commit 3981bee8f7
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Controllers/InvitationController.php
View File

@@ -38,7 +38,6 @@ class InvitationController extends Controller
$invitation->requestor_email = $request->input('email'); $invitation->requestor_email = $request->input('email');
$invitation->requestor_ip_address = $request->ip(); $invitation->requestor_ip_address = $request->ip();
$invitation->status = $guest ? 'pending' : 'approved'; $invitation->status = $guest ? 'pending' : 'approved';
$invitation->notified = !$guest; // confirmation msg doesn't count
$invitation->invitation_code = bin2hex(random_bytes(64)); $invitation->invitation_code = bin2hex(random_bytes(64));
$invitation->expiration = now()->addDays(2); $invitation->expiration = now()->addDays(2);
@@ -78,7 +77,6 @@ class InvitationController extends Controller
if ($invitation->expiration && now()->lessThanOrEqualTo($invitation->expiration) && in_array($invitation->status, $approvableStates)) if ($invitation->expiration && now()->lessThanOrEqualTo($invitation->expiration) && in_array($invitation->status, $approvableStates))
{ {
$invitation->status = 'approved'; $invitation->status = 'approved';
$invitation->notified = true;
$invitation->save(); $invitation->save();
Mail::to($invitation->requestor_email)->send(new InviteApprovedMail($invitation)); Mail::to($invitation->requestor_email)->send(new InviteApprovedMail($invitation));