refactor: code style changes
Signed-off-by: miguel456 <me@nogueira.codes>
This commit is contained in:
@@ -1,13 +1,10 @@
|
||||
<?php
|
||||
|
||||
|
||||
namespace App\Services;
|
||||
|
||||
|
||||
use App\Application;
|
||||
use App\Appointment;
|
||||
use App\Exceptions\InvalidAppointmentStatusException;
|
||||
use App\Notifications\ApplicationMoved;
|
||||
use App\Notifications\AppointmentCancelled;
|
||||
use App\Notifications\AppointmentFinished;
|
||||
use App\Notifications\AppointmentScheduled;
|
||||
@@ -30,10 +27,10 @@ class AppointmentService
|
||||
/**
|
||||
* Schedules an appointment for the provided application.
|
||||
*
|
||||
* @param Application $application The target application.
|
||||
* @param Carbon $appointmentDate The appointment's date and time.
|
||||
* @param string $appointmentDescription The appointment description.
|
||||
* @param string $appointmentLocation The appointment location.
|
||||
* @param Application $application The target application.
|
||||
* @param Carbon $appointmentDate The appointment's date and time.
|
||||
* @param string $appointmentDescription The appointment description.
|
||||
* @param string $appointmentLocation The appointment location.
|
||||
* @return bool Whether the appointment was scheduled.
|
||||
*/
|
||||
public function createAppointment(Application $application, Carbon $appointmentDate, $appointmentDescription, $appointmentLocation)
|
||||
@@ -53,22 +50,20 @@ class AppointmentService
|
||||
|
||||
$application->user->notify(new AppointmentScheduled($appointment));
|
||||
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
|
||||
/**
|
||||
* Cancels an appointment for the provided application.
|
||||
*
|
||||
* @param Application $application The target application.
|
||||
* @param string $reason The reason for cancelling the appointment.
|
||||
* @param Application $application The target application.
|
||||
* @param string $reason The reason for cancelling the appointment.
|
||||
*
|
||||
* @throws \Exception Thrown when there's no appointment to cancel
|
||||
*/
|
||||
public function deleteAppointment(Application $application, string $reason): bool
|
||||
{
|
||||
if (!empty($application->appointment))
|
||||
{
|
||||
if (! empty($application->appointment)) {
|
||||
$application->user->notify(new AppointmentCancelled($application, Carbon::parse($application->appointment->appointmentDate), $reason));
|
||||
$application->appointment->delete();
|
||||
|
||||
@@ -77,14 +72,13 @@ class AppointmentService
|
||||
Log::info('An interview appointment has just been cancelled.', [
|
||||
'actor' => Auth::user()->name,
|
||||
'applicant' => $application->user->name,
|
||||
'reason' => $reason
|
||||
'reason' => $reason,
|
||||
]);
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
throw new \Exception("This application doesn't have an appointment!");
|
||||
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -97,22 +91,17 @@ class AppointmentService
|
||||
*/
|
||||
public function updateAppointment(Application $application, $status, $updateApplication = true)
|
||||
{
|
||||
if ($status == 'SCHEDULED' || $status == 'concluded')
|
||||
{
|
||||
if ($status == 'SCHEDULED' || $status == 'concluded') {
|
||||
$application->appointment->appointmentStatus = strtoupper($status);
|
||||
$application->appointment->save();
|
||||
|
||||
if ($updateApplication)
|
||||
{
|
||||
if ($updateApplication) {
|
||||
$application->setStatus('STAGE_PEERAPPROVAL');
|
||||
$application->user->notify(new AppointmentFinished($application->appointment));
|
||||
}
|
||||
} else {
|
||||
throw new InvalidAppointmentStatusException('Invalid appointment status!');
|
||||
}
|
||||
else
|
||||
{
|
||||
throw new InvalidAppointmentStatusException("Invalid appointment status!");
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -122,5 +111,4 @@ class AppointmentService
|
||||
{
|
||||
return $this->allowedPlatforms;
|
||||
}
|
||||
|
||||
}
|
||||
|
Reference in New Issue
Block a user