miguel456/athenahr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(listeners): remove big n+1 query in user notifications

Browse Source 
Signed-off-by: miguel456 <me@nogueira.codes>
This commit is contained in:
Miguel Nogueira 2022-10-15 19:58:43 +01:00
parent 5ff1b4532a
commit 2901f76a11
No known key found for this signature in database
GPG Key ID: 3C6A7E29AF26D370
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/Listeners/OnUserRegistration.php
View File

@ -49,10 +49,11 @@ class OnUserRegistration
// TODO: Send push notification to online admins via browser (w/ pusher) // TODO: Send push notification to online admins via browser (w/ pusher)
Log::info('User '.$event->user->name.' has just registered for an account.'); Log::info('User '.$event->user->name.' has just registered for an account.');
foreach (User::all() as $user) { User::whereHas('roles', function ($q) {
if ($user->hasRole('admin')) { $q->where('name', 'admin');
$user->notify(new NewUser($event->user)); })->get()->each(function ($user, $key) use ($event) {
} $user->notify(new NewUser($event->user));
} });
} }
} }