miguel456/athenahr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove n+1 absence notification

Browse Source 
Signed-off-by: miguel456 <me@nogueira.codes>
This commit is contained in:
Miguel Nogueira
2022-11-08 00:56:56 +00:00
parent 66f6b9ffd0
commit 27ba576678
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/Services/AbsenceService.php
View File

@@ -57,9 +57,12 @@ class AbsenceService
'status' => 'PENDING', 'status' => 'PENDING',
]); ]);
foreach(User::role('admin')->get() as $admin) { User::whereHas('roles', function ($q) {
$admin->notify(new NewAbsenceRequest($absence)); $q->where('name', 'admin');
} })->get()->each(function ($user, $key) use ($absence) {
$user->notify((new NewAbsenceRequest($absence)));
});
Log::info('Processing new leave of absence request.', [ Log::info('Processing new leave of absence request.', [
'requesting_user' => $requester->email, 'requesting_user' => $requester->email,