fix: remove n+1 absence notification

Signed-off-by: miguel456 <me@nogueira.codes>
2022-11-08 00:56:56 +00:00
parent 66f6b9ffd0
commit 27ba576678
1 changed files with 6 additions and 3 deletions
--- a/app/Services/AbsenceService.php
+++ b/app/Services/AbsenceService.php
@@ -57,9 +57,12 @@ class AbsenceService
            'status' => 'PENDING',
        ]);

-        foreach(User::role('admin')->get() as $admin) {
-            $admin->notify(new NewAbsenceRequest($absence));
-        }
+        User::whereHas('roles', function ($q) {
+            $q->where('name', 'admin');
+        })->get()->each(function ($user, $key) use ($absence) {
+            $user->notify((new NewAbsenceRequest($absence)));
+        });
+

        Log::info('Processing new leave of absence request.', [
            'requesting_user' => $requester->email,