merge 1

Signed-off-by: miguel456 <me@nogueira.codes>

app/Http/Controllers/VacancyController.php

@@ -70,6 +70,8 @@ class VacancyController extends Controller
                 'discordRoleID' => $request->discordRole,
                 'vacancyFormID' => $request->vacancyFormID,
                 'vacancyCount' => $request->vacancyCount,
+                'requiresDiscord' => $request->requireDiscordAccount == 'on',
+                'requiredAge' => $request->requiredAge
 
             ]);
 
@@ -142,6 +144,8 @@ class VacancyController extends Controller
         $vacancy->vacancyFullDescription =  $request->vacancyFullDescription;
         $vacancy->vacancyDescription = $request->vacancyDescription;
         $vacancy->vacancyCount = $request->vacancyCount;
+        $vacancy->requiresDiscord = $request->requireDiscordAccount == 'on';
+        $vacancy->requiredAge = $request->requiredAge;
 
         $vacancy->save();
 
@@ -153,10 +157,18 @@ class VacancyController extends Controller
     public function delete(Request $request, Vacancy $vacancy)
     {
         $this->authorize('delete', $vacancy);
-        $vacancy->delete();
+
+        if ($vacancy->teams->isEmpty()) {
+
+            $vacancy->delete();
+
+            return redirect()
+                ->back()
+                ->with('success', __('Vacancy deleted. All applications associated with it are now gone too.'));
+        }
 
         return redirect()
             ->back()
-            ->with('success', __('Vacancy deleted. All applications associated with it are now gone too.'));
+            ->with('error', __('Please detach any teams that may be using this vacancy first.'));
     }
 }