forked from miguel456/rbrecruiter
Miguel Nogueira
5f1f92a9ce
This commit fixes some superficial instances of Broken Access Control (https://owasp.org/www-project-top-ten/OWASP_Top_Ten_2017/Top_10-2017_A5-Broken_Access_Control). There may be some more instances of this, as authorization was only done after most of the controllers were done (big mistake). Some refactoring was also performed, where Route Model Binding with DI (dependency injection) was used whenever possible, to increase testability of the codebase. Some reused code was also moved to Helper classes as to enforce DRY; There may be some lines of code that are still copy-pasted from other parts of the codebase for reuse. Non-breaking refactoring changes were made, but the app as a whole still needs full manual testing, and customised responses to HTTP 500 responses. Some errors are also not handled gracefully and this wasn't checked in this commit.
95 lines
1.8 KiB
PHP
95 lines
1.8 KiB
PHP
<?php
|
|
|
|
namespace App\Policies;
|
|
|
|
use App\Ban;
|
|
use App\User;
|
|
use Illuminate\Auth\Access\HandlesAuthorization;
|
|
|
|
class BanPolicy
|
|
{
|
|
use HandlesAuthorization;
|
|
|
|
/**
|
|
* Determine whether the user can view any models.
|
|
*
|
|
* @param \App\User $user
|
|
* @return mixed
|
|
*/
|
|
public function viewAny(User $user)
|
|
{
|
|
//
|
|
}
|
|
|
|
/**
|
|
* Determine whether the user can view the model.
|
|
*
|
|
* @param \App\User $user
|
|
* @param \App\Ban $ban
|
|
* @return mixed
|
|
*/
|
|
public function view(User $user, Ban $ban)
|
|
{
|
|
//
|
|
}
|
|
|
|
/**
|
|
* Determine whether the user can create models.
|
|
*
|
|
* @param \App\User $user
|
|
* @return mixed
|
|
*/
|
|
public function create(User $user)
|
|
{
|
|
return $user->hasRole('admin') && $user->isNot(Auth::user());
|
|
}
|
|
|
|
/**
|
|
* Determine whether the user can update the model.
|
|
*
|
|
* @param \App\User $user
|
|
* @param \App\Ban $ban
|
|
* @return mixed
|
|
*/
|
|
public function update(User $user, Ban $ban)
|
|
{
|
|
return $user->hasRole('admin');
|
|
}
|
|
|
|
/**
|
|
* Determine whether the user can delete the model.
|
|
*
|
|
* @param \App\User $user
|
|
* @param \App\Ban $ban
|
|
* @return mixed
|
|
*/
|
|
public function delete(User $user, Ban $ban)
|
|
{
|
|
return $user->hasRole('admin');
|
|
}
|
|
|
|
/**
|
|
* Determine whether the user can restore the model.
|
|
*
|
|
* @param \App\User $user
|
|
* @param \App\Ban $ban
|
|
* @return mixed
|
|
*/
|
|
public function restore(User $user, Ban $ban)
|
|
{
|
|
//
|
|
}
|
|
|
|
/**
|
|
* Determine whether the user can permanently delete the model.
|
|
*
|
|
* @param \App\User $user
|
|
* @param \App\Ban $ban
|
|
* @return mixed
|
|
*/
|
|
public function forceDelete(User $user, Ban $ban)
|
|
{
|
|
//
|
|
}
|
|
}
|