Commit Graph

8 Commits

Author SHA1 Message Date
Miguel Nogueira 2a43e213f9 RSM-81 Fix issues with Options provider 2020-10-09 23:55:46 +01:00
Miguel Nogueira 27b1f3170b Update settings log level 2020-08-31 20:02:30 +01:00
Miguel Nogueira 2afea88846 Added logging to Settings 2020-08-31 19:47:27 +01:00
Miguel Nogueira ea96cbc1f5 Options: return value instead of whole model 2020-08-31 18:54:33 +01:00
Miguel Nogueira 2996e66c8b Add missing query builder statement for options 2020-08-31 18:51:35 +01:00
Miguel Nogueira ca82f5882d Add settings page 2020-08-30 23:06:01 +01:00
Miguel Nogueira 5f1f92a9ce Code review
This commit fixes some superficial instances of Broken Access Control 
(https://owasp.org/www-project-top-ten/OWASP_Top_Ten_2017/Top_10-2017_A5-Broken_Access_Control).
There may be some more instances of this, as authorization was only done 
after most of the controllers were done (big mistake).

Some refactoring was also performed, where Route Model Binding with DI 
(dependency injection) was used whenever possible, to increase 
testability of the codebase.
Some reused code was also moved to Helper classes as to enforce DRY; 
There may be some lines of code that are still copy-pasted from other 
parts of the codebase for reuse.

Non-breaking refactoring changes were made, but the app as a whole still 
needs full manual testing, and customised responses to HTTP 500 
responses. Some errors are also not handled gracefully and this wasn't 
checked in this commit.
2020-07-16 21:21:28 +01:00
Miguel Nogueira bca6020ab0 Add ability to edit forms and add new fields
This commit adds the ability to edit and modify existing forms.
On the technical side, it also adds a new reusable validation Facade which helps reduce duplicated code.
2020-07-15 06:48:49 +01:00