From faa3a65e2b81489988a83f2e32ff77e173c06b57 Mon Sep 17 00:00:00 2001
From: Miguel Nogueira <miguel456@spacejewel-hosting.com>
Date: Mon, 31 Aug 2020 18:32:08 +0100
Subject: [PATCH] Added unchecked checkbox workaround

---
 resources/views/dashboard/administration/settings.blade.php | 5 ++++-
 routes/web.php                                              | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/resources/views/dashboard/administration/settings.blade.php b/resources/views/dashboard/administration/settings.blade.php
index fa67f9d..104b822 100644
--- a/resources/views/dashboard/administration/settings.blade.php
+++ b/resources/views/dashboard/administration/settings.blade.php
@@ -45,7 +45,10 @@
                     <form name="settings" id="settings" method="post" action="{{route('saveSettings')}}">
                         @foreach($options as $option)
                             <div class="form-group form-check">
-                                <input type="checkbox" name="{{$option->option_name}}" id="{{$option->option_name}}" class="form-check-input" {{ ($option->option_value == 1) ? 'checked' : '' }}>
+                                <!-- Unchecked checkbox hack: This only works for serverside languages that process the last duplicate element, since the browser sends both the hidden and checkbox values. -->
+                                <!-- This "hack" is necessary because browsers don't send, by default, unchecked checkboxes to the server, so we would have no way to know if X checkbox was unchecked. -->
+                                <input type="hidden" name="{{$option->option_name}}" value="0">
+                                <input type="checkbox" name="{{$option->option_name}}" value="1" id="{{$option->option_name}}" class="form-check-input" {{ ($option->option_value == 1) ? 'checked' : '' }}>
                                 <label for="{{$option->option_name}}">{{$option->friendly_name}}</label>
                             </div>
                         @endforeach
diff --git a/routes/web.php b/routes/web.php
index d7f2522..b4a788f 100644
--- a/routes/web.php
+++ b/routes/web.php
@@ -162,7 +162,7 @@ Route::group(['middleware' => ['auth', 'forcelogout', '2fa']], function(){
         Route::get('settings', 'OptionsController@index')
             ->name('showSettings');
 
-        Route::get('settings/save', 'OptionsController@saveSettings')
+        Route::post('settings/save', 'OptionsController@saveSettings')
             ->name('saveSettings');
 
         Route::post('players/ban/{user}', 'BanController@insert')